Post audit cleanup #2160
Merged
Post audit cleanup #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
force-pushed
the
post-audit-cleanup
branch
2 times, most recently
from
52a5525 to
5b999b1
Compare
This was referenced Oct 30, 2023
|
Repeating the comment here so it isn't forgotten - we need to run all the example apps to make sure they're using current APIs once #2075 is finalised. |
|
I've just run and updated all the examples. This picked up a couple of places where testbed tests weren't as robust as they could have been (they were just checking that the handler was invoked, not the arguments on the handler invocation), so those tests have been updated. |
freakboy3742
force-pushed
the
post-audit-cleanup
branch
from
c60d8f5 to
d5341dc
Compare
mhsmith
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2075.
Final cleanups after the completion of the widget audit:
@not_implementeddecorators, as the implementation tests are no longer needed.All platform should now be running without generating any warnings during testing.
Fixes #2171
PR Checklist: